Small testing QoL improvements #4800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like it got missed during the big refactor that introduced `check_output` somehow. Fixes: acbef3c Signed-off-by: Patrick Roy <[email protected]>
test_results contains files from failed tests from debugging, but the directory is created inside of a privileged docker container. Thus after finishing a test run, fix up the permissions so that it can easily be dealt with. Signed-off-by: Patrick Roy <[email protected]>
Remove `assert True` as that's just `pass` with extra steps. Remove `if bla: assert False` as that's just `assert bla` with extra steps. Signed-off-by: Patrick Roy <[email protected]>
9 tasks
roypat
added
the
Status: Awaiting review
pb8o
approved these changes
Sep 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4800 +/- ##
=======================================
Coverage 84.31% 84.32%
=======================================
Files 249 249
Lines 27521 27521
=======================================
+ Hits 23205 23206 +1
+ Misses 4316 4315 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Manciukic
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small commits that I wrote as parts of various discarded branches, but which have merit on their own. Please see individual commit messages.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.